[ 
https://issues.apache.org/jira/browse/FLINK-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150330#comment-15150330
 ] 

ASF GitHub Bot commented on FLINK-3309:
---------------------------------------

Github user chiwanpark commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1649#discussion_r53151157
  
    --- Diff: 
flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/PythonPlanBinder.java
 ---
    @@ -432,11 +436,11 @@ private void createPrintSink(PythonOperationInfo 
info) throws IOException {
        }
     
        private void createBroadcastVariable(PythonOperationInfo info) throws 
IOException {
    -           UdfOperator op1 = (UdfOperator) sets.get(info.parentID);
    -           DataSet op2 = (DataSet) sets.get(info.otherID);
    +           UdfOperator<?> op1 = (UdfOperator) sets.get(info.parentID);
    +           DataSet<?> op2 = (DataSet) sets.get(info.otherID);
     
                op1.withBroadcastSet(op2, info.name);
    -           Configuration c = ((UdfOperator) op1).getParameters();
    +           Configuration c = (op1).getParameters();
    --- End diff --
    
    Can we remove parenthesis around `op1`? (`op1.getParameters()`)


> [py] Resolve maven warnings
> ---------------------------
>
>                 Key: FLINK-3309
>                 URL: https://issues.apache.org/jira/browse/FLINK-3309
>             Project: Flink
>          Issue Type: Improvement
>          Components: Python API
>    Affects Versions: 0.10.1
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> Compiling the flink-python module generates quite a lot of maven warnings 
> about unchecked method calls etc., these should either be resolved or 
> suppressed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to