XComp commented on a change in pull request #13316:
URL: https://github.com/apache/flink/pull/13316#discussion_r491921585
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/TaskManagerMetricsInfo.java
##########
@@ -58,7 +58,19 @@
public static final String FIELD_NAME_NETWORK_MEMORY_SEGMENTS_AVAILABLE
= "memorySegmentsAvailable";
- public static final String FIELD_NAME_NETWORK_MEMROY_SEGMENTS_TOTAL =
"memorySegmentsTotal";
+ public static final String FIELD_NAME_NETWORK_MEMORY_SEGMENTS_TOTAL =
"memorySegmentsTotal";
+
+ public static final String FIELD_NAME_SHUFFLE_MEMORY_SEGMENTS_AVAILABLE
= "shuffleNettyMemorySegmentsAvailable";
Review comment:
Then, I would suggest using `shuffle` as a prefix and omit the `netty`
part. I tried to align the REST API response with the metrics naming here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
