XComp commented on a change in pull request #13316:
URL: https://github.com/apache/flink/pull/13316#discussion_r492519417
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/TaskManagerMetricsInfo.java
##########
@@ -58,7 +58,19 @@
public static final String FIELD_NAME_NETWORK_MEMORY_SEGMENTS_AVAILABLE
= "memorySegmentsAvailable";
- public static final String FIELD_NAME_NETWORK_MEMROY_SEGMENTS_TOTAL =
"memorySegmentsTotal";
+ public static final String FIELD_NAME_NETWORK_MEMORY_SEGMENTS_TOTAL =
"memorySegmentsTotal";
+
+ public static final String FIELD_NAME_SHUFFLE_MEMORY_SEGMENTS_AVAILABLE
= "shuffleNettyMemorySegmentsAvailable";
Review comment:
We discussed the naming offline. Here's the summary:
We're gonna go with @azagrebin's proposal `nettyShuffle` as the main
component here is the shuffle component. The only current shuffle algorithm
implemented is based on netty. Efforts to introduce other algorithms were
postponed. We might have to revisit the API, anyway, when adding new algorithms.
##########
File path: flink-runtime-web/src/test/resources/rest_api_v1.snapshot
##########
@@ -3082,4 +3100,4 @@
}
}
} ]
-}
+}
Review comment:
Yes, I opened the file using `vi`, once. My `vi` is set up to remove the
last `\n` if present. Good catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
