rmetzger edited a comment on pull request #13412: URL: https://github.com/apache/flink/pull/13412#issuecomment-696068305
I looked a bit into your change. I can not guarantee that my comments are pointing you in the right direction. I have no prior experience with the `ExecutionGraph`. I believe it would be helpful to add test cases for edge cases such as "cancellation while finalizeOnMaster is blocked" and maybe an integration test with a slow `finalizeOnMaster` call to make sure no other components are affected (I see calls to release partitions "nearby"). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
