AHeise commented on a change in pull request #13228:
URL: https://github.com/apache/flink/pull/13228#discussion_r493035866
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/StreamTaskNetworkInputTest.java
##########
@@ -120,67 +112,10 @@ public void testNoDataProcessedAfterCheckpointBarrier()
throws Exception {
assertEquals(0, output.getNumberOfEmittedRecords());
}
- @Test
- public void testSnapshotWithTwoInputGates() throws Exception {
Review comment:
I added this test for FLINK-18139 - input gate index issues in
`Unaligner#hasInflightData`, which is called by `StreamTaskNetworkInput`, hence
the test here.
However, in this commit, `hasInflightData` is removed. Spilling is fully
encapsulated in `InputChannel` +
`CheckpointBarrierUnaligner`/`CheckpointedInputGate` and this interaction is
already covered in tests at `CheckpointBarrierUnalignerTest`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
