AHeise commented on a change in pull request #13228:
URL: https://github.com/apache/flink/pull/13228#discussion_r493039856



##########
File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGateTest.java
##########
@@ -812,242 +788,13 @@ public void testQueuedBuffers() throws Exception {
                }
        }
 
-       @Test
-       public void testBufferReceivedListener() throws Exception {

Review comment:
       Good catch, my intent was to delete `testBufferReceivedListener` and 
`testPartitionNotFoundExceptionWhileGetNextBuffer` but not the test in between 
them.
   
   `testBufferReceivedListener` tests `BufferReceivedListener` which this 
commits renders useless (and is later removed).
   
   `testPartitionNotFoundExceptionWhileGetNextBuffer` tests concurrent spilling 
of lingering buffers and receiving of such lingering buffers. Both now happens 
in the same thread, so the test does not make any sense.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to