dawidwys commented on a change in pull request #13423:
URL: https://github.com/apache/flink/pull/13423#discussion_r493592305



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractInput.java
##########
@@ -68,4 +68,13 @@ public void processLatencyMarker(LatencyMarker 
latencyMarker) throws Exception {
        public void setKeyContextElement(StreamRecord record) throws Exception {
                owner.internalSetKeyContextElement(record, stateKeySelector);
        }
+
+       @Override
+       public void endInput() throws Exception {
+               if (owner instanceof BoundedOneInput && inputId == 1) {

Review comment:
       BTW, shouldn't the `BoundedMultiInput` extend from `BoundedOneInput`?
   
   ```
   interface BoundedMultiInput extends BoundedOneInput {
    
           default void endInput() throws Exception {
               endInput(1)
           }
   
        /**
         * It is notified that no more data will arrive on the input identified 
by the {@code inputId}.
         * The {@code inputId} is numbered starting from 1, and `1` indicates 
the first input.
         */
        void endInput(int inputId) throws Exception;
   }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to