XComp commented on a change in pull request #13458:
URL: https://github.com/apache/flink/pull/13458#discussion_r493689536
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointStatistics.java
##########
@@ -113,6 +114,9 @@
@JsonProperty(FIELD_NAME_NUM_ACK_SUBTASKS)
private final int numAckSubtasks;
+ @JsonProperty(FIELD_NAME_CHECK_POINT_TYPE)
+ private final String checkPointType;
Review comment:
We might want to stick to `CheckpointType` here instead of `String`
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointStatistics.java
##########
@@ -18,6 +18,14 @@
package org.apache.flink.runtime.rest.messages.checkpoints;
+import java.util.Collection;
Review comment:
The introduced code format does not comply with [Flink's checkstyle
format](https://ci.apache.org/projects/flink/flink-docs-stable/flinkDev/ide_setup.html#checkstyle-for-java).
Ideally, code changes shouldn't be accompanied with format changes.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointStatistics.java
##########
@@ -83,6 +82,8 @@
public static final String FIELD_NAME_TASKS = "tasks";
+ public static final String FIELD_NAME_CHECK_POINT_TYPE =
"check_point_type";
Review comment:
"checkpoint" is one word. Hence, we should name variables, classes, and
other literals like accordingly, i.e. `FIELD_NAME_CHECKPOINT_TYPE`,
`"checkpoint_type"`, or `checkpointType`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
