XComp commented on a change in pull request #13458:
URL: https://github.com/apache/flink/pull/13458#discussion_r494079037
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointStatistics.java
##########
@@ -18,32 +18,22 @@
package org.apache.flink.runtime.rest.messages.checkpoints;
-import org.apache.flink.runtime.checkpoint.AbstractCheckpointStats;
-import org.apache.flink.runtime.checkpoint.CheckpointStatsStatus;
-import org.apache.flink.runtime.checkpoint.CompletedCheckpointStats;
-import org.apache.flink.runtime.checkpoint.FailedCheckpointStats;
-import org.apache.flink.runtime.checkpoint.PendingCheckpointStats;
-import org.apache.flink.runtime.checkpoint.TaskStateStats;
+import org.apache.flink.runtime.checkpoint.*;
Review comment:
The imports are still not compliant with the CheckStyle format defined
for Flink. Please use [Flink's CheckStyle format
definition](https://ci.apache.org/projects/flink/flink-docs-stable/flinkDev/ide_setup.html#checkstyle-for-java)
to fix the formatting.
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointingStatisticsTest.java
##########
@@ -82,6 +82,7 @@ protected CheckpointingStatistics getTestResponseInstance()
throws Exception {
0L,
10,
10,
+ "Checkpoint",
Review comment:
There's a compilation error after the parameter type changed to the
`CheckpointType` enum.
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointingStatisticsTest.java
##########
@@ -133,6 +136,7 @@ protected CheckpointingStatistics getTestResponseInstance()
throws Exception {
0L,
10,
10,
+ "Checkpoint",
Review comment:
There's a compilation error after the parameter type changed to the
`CheckpointType` enum.
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointingStatisticsTest.java
##########
@@ -97,6 +98,7 @@ protected CheckpointingStatistics getTestResponseInstance()
throws Exception {
0L,
9,
9,
+ "Savepoint",
Review comment:
There's a compilation error after the parameter type changed to the
`CheckpointType` enum.
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointingStatisticsTest.java
##########
@@ -112,6 +114,7 @@ protected CheckpointingStatistics getTestResponseInstance()
throws Exception {
0L,
11,
9,
+ "Checkpoint",
Review comment:
There's a compilation error after the parameter type changed to the
`CheckpointType` enum.
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointingStatisticsTest.java
##########
@@ -18,15 +18,15 @@
package org.apache.flink.runtime.rest.messages.checkpoints;
-import org.apache.flink.runtime.checkpoint.CheckpointStatsStatus;
-import org.apache.flink.runtime.jobgraph.JobVertexID;
-import org.apache.flink.runtime.rest.messages.RestResponseMarshallingTestBase;
-
import java.util.Arrays;
import java.util.Collections;
import java.util.HashMap;
import java.util.Map;
+import org.apache.flink.runtime.checkpoint.CheckpointStatsStatus;
Review comment:
The imports are still not compliant with the CheckStyle format defined
for Flink. Please use [Flink's CheckStyle format
definition](https://ci.apache.org/projects/flink/flink-docs-stable/flinkDev/ide_setup.html#checkstyle-for-java)
to fix the formatting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
