Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1553#discussion_r53153386
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/GroupReduceITCase.java
---
@@ -434,6 +431,95 @@ public void
testCorrectnessOfGroupreduceWithDescendingGroupSort() throws Excepti
}
@Test
+ public void
testCorrectnessOfGroupreduceWithExplicitPartitionOfReducer() throws Exception {
+ /*
+ * check correctness of groupReduce with descending group sort
+ */
+ final ExecutionEnvironment env =
ExecutionEnvironment.getExecutionEnvironment();
+ env.setParallelism(1);
--- End diff --
If we run this test with parallelism `1`, we cannot check if the
partitioning is working correctly. Also use a custom `GroupReduceFunction` that
implements the `GroupCombineFunction` interface. The combine function should be
implemented in a way that we can actually verify that it was called.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
