Github user ramkrish86 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1553#discussion_r53978205
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/GroupReduceITCase.java
 ---
    @@ -434,6 +431,95 @@ public void 
testCorrectnessOfGroupreduceWithDescendingGroupSort() throws Excepti
        }
     
        @Test
    +   public void 
testCorrectnessOfGroupreduceWithExplicitPartitionOfReducer() throws Exception {
    +           /*
    +            * check correctness of groupReduce with descending group sort
    +            */
    +           final ExecutionEnvironment env = 
ExecutionEnvironment.getExecutionEnvironment();
    +           env.setParallelism(1);
    --- End diff --
    
    Is it ok if I modify the existing test 
testCorrectnessOfGroupReduceOnTuplesWithCombine() and add a partitionByHash to 
the input dataset? I tested and debugged it and it seems to work fine after the 
changes and gives the same expected result as given by 
testCorrectnessOfGroupReduceOnTuplesWithCombine().


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to