wangyang0918 commented on a change in pull request #13322:
URL: https://github.com/apache/flink/pull/13322#discussion_r494017153
##########
File path:
flink-end-to-end-tests/test-scripts/test_kubernetes_pyflink_application.sh
##########
@@ -0,0 +1,57 @@
+#!/usr/bin/env bash
Review comment:
I think you need to start the `test_kubernetes_application.sh` in
`run-nightly-tests.sh`.
##########
File path:
flink-python/src/test/java/org/apache/flink/client/cli/PythonProgramOptionsTest.java
##########
@@ -81,7 +92,7 @@ public void testCreateProgramOptionsWithPythonCommandLine()
throws CliArgsExcept
}
@Test
- public void testCreateProgramOptionsWithLongOptions() throws
CliArgsException {
+ public void testCreateProgramOzptionsWithLongOptions() throws
CliArgsException {
Review comment:
Why do we change the test name?
##########
File path:
flink-python/src/test/java/org/apache/flink/client/cli/PythonProgramOptionsTest.java
##########
@@ -104,4 +114,45 @@ public void testCreateProgramOptionsWithLongOptions()
throws CliArgsException {
new String[] {"--python", "xxx.py", "--pyModule",
"xxx", "userarg1", "userarg2"},
programOptions.getProgramArgs());
}
+
+ @Test
+ public void testConfigurePythonExecution() throws
IllegalAccessException, NoSuchFieldException, CliArgsException,
ProgramInvocationException, IOException {
+ String[] args = {
Review comment:
nit: `final` here.
##########
File path:
flink-end-to-end-tests/test-scripts/test_kubernetes_pyflink_application.sh
##########
@@ -0,0 +1,57 @@
+#!/usr/bin/env bash
Review comment:
I think you need to start the `test_kubernetes_pyflink_application.sh`
in `run-nightly-tests.sh`.
##########
File path:
flink-python/src/test/java/org/apache/flink/client/cli/PythonProgramOptionsTest.java
##########
@@ -104,4 +114,45 @@ public void testCreateProgramOptionsWithLongOptions()
throws CliArgsException {
new String[] {"--python", "xxx.py", "--pyModule",
"xxx", "userarg1", "userarg2"},
programOptions.getProgramArgs());
}
+
+ @Test
+ public void testConfigurePythonExecution() throws
IllegalAccessException, NoSuchFieldException, CliArgsException,
ProgramInvocationException, IOException {
+ String[] args = {
Review comment:
nit: `final` here. And the following variables.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
