[
https://issues.apache.org/jira/browse/FLINK-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152740#comment-15152740
]
ASF GitHub Bot commented on FLINK-3443:
---------------------------------------
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/1669
[FLINK-3443] [runtime] Prevent cancelled jobs from restarting
After JobManager shut down, it was possible that jobs were restarted,
because the execution graphs were failed and not cancelled. Although I would
have expected the ExecutorService shutdown to handle this, it did not (seen in
log files, if you don't immediately shut down the JVM after a test).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/flink graph-cancelandclear
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1669.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1669
----
----
> JobManager cancel and clear everything fails jobs instead of cancelling
> -----------------------------------------------------------------------
>
> Key: FLINK-3443
> URL: https://issues.apache.org/jira/browse/FLINK-3443
> Project: Flink
> Issue Type: Bug
> Components: Distributed Runtime
> Reporter: Ufuk Celebi
> Assignee: Ufuk Celebi
>
> When the job manager is shut down, it calls {{cancelAndClearEverything}}.
> This method does not {{cancel}} the {{ExecutionGraph}} instances, but
> {{fail}}s them, which can lead to {{ExecutionGraph}} restart.
> I've noticed this in tests, where old graph got into a loop of restarts.
> What I don't understand is why the futures etc. are not cancelled when the
> executor service is shut down.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
