[
https://issues.apache.org/jira/browse/FLINK-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157536#comment-15157536
]
ASF GitHub Bot commented on FLINK-3443:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1669#discussion_r53677748
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1487,7 +1487,7 @@ class JobManager(
}
}
- eg.fail(cause)
+ eg.cancel()
--- End diff --
Yes, currently it is the case that state is removed from ZooKeeper when you
shut down the cluster and run `postStop`. Do you think that this is a problem?
I've created https://issues.apache.org/jira/browse/FLINK-3411 last week for
a related issue: if all execution retries (current default with checkpointing
is `Integer.MAX_VALUE`) are exhausted, state is removed as well.
> JobManager cancel and clear everything fails jobs instead of cancelling
> -----------------------------------------------------------------------
>
> Key: FLINK-3443
> URL: https://issues.apache.org/jira/browse/FLINK-3443
> Project: Flink
> Issue Type: Bug
> Components: Distributed Runtime
> Reporter: Ufuk Celebi
> Assignee: Ufuk Celebi
>
> When the job manager is shut down, it calls {{cancelAndClearEverything}}.
> This method does not {{cancel}} the {{ExecutionGraph}} instances, but
> {{fail}}s them, which can lead to {{ExecutionGraph}} restart.
> I've noticed this in tests, where old graph got into a loop of restarts.
> What I don't understand is why the futures etc. are not cancelled when the
> executor service is shut down.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
