dawidwys commented on a change in pull request #13509:
URL: https://github.com/apache/flink/pull/13509#discussion_r496908170
##########
File path: docs/dev/event_time.md
##########
@@ -1,4 +1,4 @@
----
+--
Review comment:
I think that's a mistake.
##########
File path:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java
##########
@@ -262,14 +259,6 @@ public static void main(String[] args) throws Exception {
env.enableCheckpointing(1000L,
CheckpointingMode.AT_LEAST_ONCE);
}
- // enable watermark or not
- if (EVENT_TIME.equals(timeType)) {
Review comment:
Remove also the `timeType` variable
##########
File path:
flink-examples/flink-examples-streaming/src/main/scala/org/apache/flink/streaming/scala/examples/ml/IncrementalLearningSkeleton.scala
##########
@@ -62,19 +60,18 @@ object IncrementalLearningSkeleton {
// set up the execution environment
val env = StreamExecutionEnvironment.getExecutionEnvironment
- env.setStreamTimeCharacteristic(TimeCharacteristic.EventTime)
// build new model on every second of new data
- val trainingData: DataStream[Int] = env.addSource(new
FiniteTrainingDataSource)
- val newData: DataStream[Int] = env.addSource(new FiniteNewDataSource)
+ val trainingData: DataStream[Integer] = env.addSource(new
FiniteTrainingDataSource)
Review comment:
Why did we have to change to java classes here?
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/TimeCharacteristic.java
##########
@@ -19,12 +19,26 @@
package org.apache.flink.streaming.api;
import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.api.common.ExecutionConfig;
+import org.apache.flink.api.common.eventtime.WatermarkStrategy;
/**
- * The time characteristic defines how the system determines time for
time-dependent
- * order and operations that depend on time (such as time windows).
+ * The time characteristic defines how the system determines time for
time-dependent order and
+ * operations that depend on time (such as time windows).
+ *
+ * @deprecated In Flink 1.12 the default stream time characteristic has been
changed to {@link
Review comment:
nit: I am not entirely sure, but I think 1.12 is the first release with
python DataStream API. If that's the case I think we don't need to mention the
change of the default value here.
It doesn't harm though, therefore I am fine with either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
