aljoscha commented on a change in pull request #13509:
URL: https://github.com/apache/flink/pull/13509#discussion_r497326267
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -719,12 +719,24 @@ public void registerType(Class<?> type) {
* time, event time, or ingestion time.
*
* <p>If you set the characteristic to IngestionTime of EventTime this
will set a default
- * watermark update interval of 200 ms. If this is not applicable for
your application
- * you should change it using {@link
ExecutionConfig#setAutoWatermarkInterval(long)}.
+ * watermark update interval of 200 ms. If this is not applicable for
your application you
+ * should change it using {@link
ExecutionConfig#setAutoWatermarkInterval(long)}.
*
* @param characteristic The time characteristic.
+ *
+ * @deprecated In Flink 1.12 the default stream time characteristic has
been changed to {@link
+ * TimeCharacteristic#EventTime}, thus you don't need to call
this method for enabling
+ * event-time support anymore. Explicitly using
processing-time windows and timers works in
+ * event-time mode. If you need to disable watermarks,
please use {@link
+ * ExecutionConfig#setAutoWatermarkInterval(long)}. If you are
using {@link
Review comment:
Good point! I would update the Javadoc of `setAutoWatermarkInterval()`
to mention that setting it to `0` will disable it. I'm reluctant to add it here
because the message is already very long. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
