[ 
https://issues.apache.org/jira/browse/FLINK-19497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209011#comment-17209011
 ] 

Chesnay Schepler commented on FLINK-19497:
------------------------------------------

I would be hesitant since it is conceivable that it changes behavior; if there 
is code out there incrementing the counter from the dropwizard side without the 
user being aware of it.
It's also not really a bug; the wrappers weren't really intended to be used in 
a general-purpose fashion and mostly exist for our reporter use-case; another 
reminder to only make things public if you really need to :/

It should fortunately be straight-forward to temporarily use a copy of the 
modified class in your project.

> Implement mutator methods for FlinkCounterWrapper
> -------------------------------------------------
>
>                 Key: FLINK-19497
>                 URL: https://issues.apache.org/jira/browse/FLINK-19497
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Metrics
>    Affects Versions: 1.10.2, 1.11.2
>            Reporter: Richard Moorhead
>            Assignee: Richard Moorhead
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.12.0
>
>
> Looking at the dropwizard wrapper classes in flink-metrics-dropwizard, it 
> appears that all of them have mutator methods defined with the exception of 
> FlinkCounterWrapper. We have a use case wherein we mutate counters from a 
> dropwizard context but wish the underlying metrics in the flink registry to 
> be updated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to