dawidwys commented on a change in pull request #13529: URL: https://github.com/apache/flink/pull/13529#discussion_r501060318
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamMultipleInputProcessorFactory.java ########## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.runtime.io; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.metrics.Counter; +import org.apache.flink.metrics.SimpleCounter; +import org.apache.flink.runtime.io.disk.iomanager.IOManager; +import org.apache.flink.runtime.metrics.groups.TaskIOMetricGroup; +import org.apache.flink.streaming.api.graph.StreamConfig; +import org.apache.flink.streaming.api.operators.Input; +import org.apache.flink.streaming.api.operators.MultipleInputStreamOperator; +import org.apache.flink.streaming.api.operators.Output; +import org.apache.flink.streaming.api.watermark.Watermark; +import org.apache.flink.streaming.runtime.metrics.WatermarkGauge; +import org.apache.flink.streaming.runtime.streamrecord.LatencyMarker; +import org.apache.flink.streaming.runtime.streamrecord.StreamRecord; +import org.apache.flink.streaming.runtime.streamstatus.StatusWatermarkValve; +import org.apache.flink.streaming.runtime.streamstatus.StreamStatus; +import org.apache.flink.streaming.runtime.streamstatus.StreamStatusMaintainer; +import org.apache.flink.streaming.runtime.tasks.OperatorChain; +import org.apache.flink.streaming.runtime.tasks.SourceOperatorStreamTask; + +import java.util.Arrays; +import java.util.List; + +import static org.apache.flink.util.Preconditions.checkNotNull; +import static org.apache.flink.util.Preconditions.checkState; + +/** + * A factory for {@link StreamMultipleInputProcessor}. + */ +@Internal +public class StreamMultipleInputProcessorFactory { + + @SuppressWarnings({"unchecked", "rawtypes"}) + public static StreamMultipleInputProcessor create( + CheckpointedInputGate[] checkpointedInputGates, + StreamConfig.InputConfig[] configuredInputs, + IOManager ioManager, + TaskIOMetricGroup ioMetricGroup, + Counter mainOperatorRecordsIn, + StreamStatusMaintainer streamStatusMaintainer, + MultipleInputStreamOperator<?> mainOperator, + MultipleInputSelectionHandler inputSelectionHandler, + WatermarkGauge[] inputWatermarkGauges, + OperatorChain<?, ?> operatorChain) { + checkNotNull(operatorChain); + checkNotNull(inputSelectionHandler); + + List<Input> operatorInputs = mainOperator.getInputs(); + int inputsCount = operatorInputs.size(); + + StreamOneInputProcessor<?>[] inputProcessors = new StreamOneInputProcessor[inputsCount]; + Counter networkRecordsIn = new SimpleCounter(); + ioMetricGroup.reuseRecordsInputCounter(networkRecordsIn); + + MultiStreamStreamStatusTracker streamStatusTracker = new MultiStreamStreamStatusTracker(inputsCount); + checkState( + configuredInputs.length == inputsCount, + "Number of configured inputs in StreamConfig [%s] doesn't match the main operator's number of inputs [%s]", + configuredInputs.length, + inputsCount); + for (int i = 0; i < inputsCount; i++) { + StreamConfig.InputConfig configuredInput = configuredInputs[i]; + if (configuredInput instanceof StreamConfig.NetworkInputConfig) { + StreamConfig.NetworkInputConfig networkInput = (StreamConfig.NetworkInputConfig) configuredInput; + StreamTaskNetworkOutput dataOutput = new StreamTaskNetworkOutput<>( + operatorInputs.get(i), + streamStatusMaintainer, + inputWatermarkGauges[i], + inputSelectionHandler, streamStatusTracker, + i, + mainOperatorRecordsIn, + networkRecordsIn); + + inputProcessors[i] = new StreamOneInputProcessor( + new StreamTaskNetworkInput<>( + checkpointedInputGates[networkInput.getInputGateIndex()], + networkInput.getTypeSerializer(), + ioManager, + new StatusWatermarkValve(checkpointedInputGates[networkInput.getInputGateIndex()].getNumberOfInputChannels()), + i), + dataOutput, + operatorChain); + } + else if (configuredInput instanceof StreamConfig.SourceInputConfig) { + StreamConfig.SourceInputConfig sourceInput = (StreamConfig.SourceInputConfig) configuredInput; + Output<StreamRecord<?>> chainedSourceOutput = operatorChain.getChainedSourceOutput(sourceInput); + StreamTaskSourceInput<?> sourceTaskInput = operatorChain.getSourceTaskInput(sourceInput); + + inputProcessors[i] = new StreamOneInputProcessor( + sourceTaskInput, + new StreamTaskSourceOutput(chainedSourceOutput, streamStatusMaintainer, inputWatermarkGauges[i], + streamStatusTracker, + i), + operatorChain); + } + else { + throw new UnsupportedOperationException("Unknown input type: " + configuredInput); + } + } + + return new StreamMultipleInputProcessor( + inputSelectionHandler, + inputProcessors + ); + } + + + /** + * Stream status tracker for the inputs. We need to keep track for determining when + * to forward stream status changes downstream. + */ + private static class MultiStreamStreamStatusTracker { + private final StreamStatus[] streamStatuses; + + private MultiStreamStreamStatusTracker(int numberOfInputs) { + this.streamStatuses = new StreamStatus[numberOfInputs]; + Arrays.fill(streamStatuses, StreamStatus.ACTIVE); + } + + public void setStreamStatus(int index, StreamStatus streamStatus) { + streamStatuses[index] = streamStatus; + } + + public StreamStatus getStreamStatus(int index) { + return streamStatuses[index]; + } + + public boolean allStreamStatusesAreIdle() { + for (StreamStatus streamStatus : streamStatuses) { + if (streamStatus.isActive()) { + return false; + } + } + return true; + } + } Review comment: Yes, you are correct. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
