dawidwys commented on a change in pull request #13529:
URL: https://github.com/apache/flink/pull/13529#discussion_r501541918
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTwoInputProcessor.java
##########
@@ -124,6 +120,7 @@ private int selectFirstReadingInputIndex() throws
IOException {
}
private void checkFinished(InputStatus status) throws Exception {
+ updateAvailability();
Review comment:
The commit is unnecessary. I did not fully understand the availability
handling.
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTwoInputProcessor.java
##########
@@ -171,6 +168,10 @@ private int selectNextReadingInputIndex() throws
IOException {
updateAvailability();
checkInputSelectionAgainstIsFinished();
+ if (inputSelectionHandler.isInputUnavailable(0) &&
inputSelectionHandler.isInputUnavailable(1)) {
+ fullCheckAndSetAvailable();
+ }
Review comment:
The commit is unnecessary. I did not fully understand the availability
handling.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
