XComp edited a comment on pull request #13547:
URL: https://github.com/apache/flink/pull/13547#issuecomment-706126279


   > Hi, @XComp
   > both solutions work for me
   > but I suggest not to remove the metric information from the 
`TaskManagerDetailsHandler` since it would bring break changes to the Rest API, 
what about keep consistent with the previous design?
   > we can refactor all the Rest API later version (maybe v2?)
   
   Thanks for your opinion. I agree with removing the metric information 
shouldn't be done right away. But we might consider it when thinking about 
updating the REST API in general having `v2` (as you mentioned as well with). 
There were a few things about the REST API that we could improve. Having a 
ticket proposing the cleanup of the metrics in the REST endpoint's response is 
just for documentation purposes for now.
   
   I would propose removing the REST API update from this PR. Instead, you 
would use the metric endpoint when resolving 
[FLINK-15328](https://issues.apache.org/jira/browse/FLINK-15328).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to