rmetzger commented on pull request #13457: URL: https://github.com/apache/flink/pull/13457#issuecomment-708603602
> The log4j-cli.properties logs to a file and doesn't use a rolling policy, I can change that to rolling. Let's leave that as-is. The logfile is overwritten on every cli start anyways. > The log4j-console.properties uses the rolling policy and max files to keep is set to 10. Maybe it makes sense to do the same for log4j.properties. Yes, I agree. That way, we bound the log files directory size to roughly 1GB, which is a good safety net. > Then I noticed that there is a CoreOptions.FLINK_LOG_MAX config parameter, is it save to remove it? This will not be used anymore. @zentol are we considering these config options part of the stable API? I don't think this setting is used much, if at all. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
