rmetzger commented on pull request #13457:
URL: https://github.com/apache/flink/pull/13457#issuecomment-713101595


   I'm really sorry that I'm only responding to you every 5 days. I'd actually 
like to keep a certain momentum going with this change.  I'll try to get back 
faster!
   
   I had an offline discussion with @zentol about the configuration parameter. 
Since it is documented, we treat it as public API, which we cannot break 
between minor releases.
   However, he also wondered why we can't forward the configured FLINK_LOG_MAX 
value to the log4j settings? 
   
   ```
   appender.main.policies.type = Policies
   appender.main.policies.size.type = SizeBasedTriggeringPolicy
   appender.main.policies.size.size = 100MB
   appender.main.policies.startup.type = OnStartupTriggeringPolicy
   appender.main.strategy.type = DefaultRolloverStrategy
   appender.main.strategy.max = ${env:MAX_LOG_FILE_NUMBER:-10}
   ```
   
   I have tried this locally and it seems to work.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to