dawidwys commented on a change in pull request #13656:
URL: https://github.com/apache/flink/pull/13656#discussion_r506155607
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java
##########
@@ -244,19 +245,30 @@ private void configureStreamGraph(final StreamGraph
graph) {
}
private boolean shouldExecuteInBatchMode(final RuntimeExecutionMode
configuredMode) {
+ final boolean existsUnboundedSource = existsContinuousSource();
+
+ if (configuredMode == RuntimeExecutionMode.BATCH &&
existsUnboundedSource) {
Review comment:
In similar cases I went with `state` because it is not obvious which
`argument` on which method is illegal. Usually I'd use `argument` if it is
thrown explicitly from a method that is called by the recipient of the
exception. But I do agree the `state` is also not a perfect solution as it is
because of a user setting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
