godfreyhe commented on a change in pull request #13625:
URL: https://github.com/apache/flink/pull/13625#discussion_r506540225
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/batch/BatchExecCalcBase.scala
##########
@@ -112,11 +111,11 @@ abstract class BatchExecCalcBase(
//~ ExecNode methods
-----------------------------------------------------------
- override def getDamBehavior = DamBehavior.PIPELINED
-
override def getInputNodes: util.List[ExecNode[BatchPlanner, _]] =
List(getInput.asInstanceOf[ExecNode[BatchPlanner, _]])
+ override def getInputEdges: util.List[ExecEdge] =
List(ExecEdge.builder().build())
Review comment:
create a default ExecEdge instance ?
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/reuse/DeadlockBreakupProcessor.scala
##########
@@ -320,8 +319,9 @@ class DeadlockBreakupProcessor extends DAGProcessor {
// should exclude the reused node (at last position in path)
while (!hasFullDamNode && idx < inputPath.length - 1) {
val node = inputPath(idx)
- val nodeDamBehavior =
node.asInstanceOf[BatchExecNode[_]].getDamBehavior
- hasFullDamNode = if (nodeDamBehavior == DamBehavior.FULL_DAM) {
+ val atLeastEndInput = node.getInputEdges.forall(
+ e =>
e.getDamBehavior.stricterOrEqual(ExecEdge.DamBehavior.END_INPUT))
+ hasFullDamNode = if (atLeastEndInput) {
true
} else {
node match {
Review comment:
we should avoid match specific class here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
