godfreyhe commented on a change in pull request #13625:
URL: https://github.com/apache/flink/pull/13625#discussion_r506909706
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/exec/StreamExecNode.scala
##########
@@ -21,7 +21,19 @@ package org.apache.flink.table.planner.plan.nodes.exec
import org.apache.flink.table.planner.delegation.StreamPlanner
import org.apache.flink.table.planner.utils.Logging
+import java.util
+
/**
* Base class for stream ExecNode.
*/
-trait StreamExecNode[T] extends ExecNode[StreamPlanner, T] with Logging
+trait StreamExecNode[T] extends ExecNode[StreamPlanner, T] with Logging {
+
+ def getInputEdges: util.List[ExecEdge] = {
+ // TODO fill out the required shuffle for each stream exec node
+ val edges = new util.ArrayList[ExecEdge]()
+ for (_ <- 0 until getInputNodes.size()) {
+ edges.add(ExecEdge.DEFAULT)
+ }
+ edges
Review comment:
nit: can be simplified as `getInputNodes.map(_ => ExecEdge.DEFAULT)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
