aljoscha commented on a change in pull request #13554:
URL: https://github.com/apache/flink/pull/13554#discussion_r507626849
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/cli/DefaultCLI.java
##########
@@ -37,16 +38,24 @@
*/
public class DefaultCLI extends AbstractCustomCommandLine {
+ public static final String ID = "default";
+
private static final Option addressOption = new Option("m",
"jobmanager", true,
"Address of the JobManager to which to connect. " +
"Use this flag to connect to a different JobManager
than the one specified in the configuration. " +
"Attention: This option is respected only if the
high-availability configuration is NONE.");
- public static final String ID = "default";
-
- public DefaultCLI(Configuration configuration) {
- super(configuration);
- }
+ /**
+ * Dynamic properties allow the user to specify additional
configuration values with -D, such as
+ * <tt> -Dfs.overwrite-files=true
-Dtaskmanager.memory.network.min=536346624</tt>.
+ */
Review comment:
I'll move it to a Util. Unfortunately, the `GenericCLI` and `DefaultCLI`
don't have a common base class. And I also don't want to touch the dynamic
properties code of the `FlinkYarnSessionCli` which is yet another story... 😅
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
