aljoscha commented on a change in pull request #13554:
URL: https://github.com/apache/flink/pull/13554#discussion_r507627981
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java
##########
@@ -892,15 +895,20 @@ private JobID parseJobId(String jobIdString) throws
CliArgsException {
* @throws FlinkException if something goes wrong
*/
private <ClusterID> void runClusterAction(CustomCommandLine
activeCommandLine, CommandLine commandLine, ClusterAction<ClusterID>
clusterAction) throws FlinkException {
- final Configuration executorConfig =
activeCommandLine.applyCommandLineOptionsToConfiguration(commandLine);
- final ClusterClientFactory<ClusterID> clusterClientFactory =
clusterClientServiceLoader.getClusterClientFactory(executorConfig);
+ final Configuration effectiveConfiguration = new
Configuration(configuration);
+ final Configuration commandLineConfiguration =
activeCommandLine.toConfiguration(commandLine);
+ effectiveConfiguration.addAll(commandLineConfiguration);
- final ClusterID clusterId =
clusterClientFactory.getClusterId(executorConfig);
+ LOG.debug("Effective configuration: {}",
effectiveConfiguration);
Review comment:
Will add that. 👌
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
