aljoscha commented on a change in pull request #13698:
URL: https://github.com/apache/flink/pull/13698#discussion_r508295090
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java
##########
@@ -266,6 +266,12 @@ private void configureStreamGraph(final StreamGraph graph)
{
graph.setJobName(jobName);
if (shouldExecuteInBatchMode) {
+
+ if (checkpointConfig.isCheckpointingEnabled()) {
+ LOG.info("Disabled Checkpointing. Checkpointing
is not supported when executing jobs in BATCH mode.");
+ checkpointConfig.disableCheckpointing();
Review comment:
I don't like that we're setting it on the `CheckpointConfig` that the
user gave to us. I think it's in general not good that we just pass this
through but now is the first time that we modify it here, I think.
Maybe we should do an internal copy of the checkpoint config and then we can
modify it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
