kl0u commented on a change in pull request #13698:
URL: https://github.com/apache/flink/pull/13698#discussion_r508332076
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java
##########
@@ -266,6 +266,12 @@ private void configureStreamGraph(final StreamGraph graph)
{
graph.setJobName(jobName);
if (shouldExecuteInBatchMode) {
+
+ if (checkpointConfig.isCheckpointingEnabled()) {
+ LOG.info("Disabled Checkpointing. Checkpointing
is not supported when executing jobs in BATCH mode.");
+ checkpointConfig.disableCheckpointing();
Review comment:
I agree. The only thing I am afraid is if at any point we are taking
again the checkpoint config from the `env` and we disregard what the
`StreamGraphGenerator` has set. From a quick look, it does not seem to be the
case, so I pushed another commit with the change. Please have a look and let me
know what you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
