kylemeow commented on a change in pull request #13706:
URL: https://github.com/apache/flink/pull/13706#discussion_r508956321



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
##########
@@ -606,7 +608,12 @@ private void releaseEmptyTaskManager(ResourceID 
resourceId) {
 
                final TaskManagerLocation taskManagerLocation;
                try {
-                       taskManagerLocation = 
TaskManagerLocation.fromUnresolvedLocation(unresolvedTaskManagerLocation);
+                       final boolean retrieveTaskManagerHostName = 
this.jobMasterConfiguration.getConfiguration()
+                                       
.getBoolean(JobManagerOptions.RETRIEVE_TASK_MANAGER_HOSTNAME);

Review comment:
       Thank you for the suggestion, I have moved this variable to a field in 
*JobMaster*.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to