kylemeow commented on a change in pull request #13706:
URL: https://github.com/apache/flink/pull/13706#discussion_r508956726
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
##########
@@ -606,7 +608,12 @@ private void releaseEmptyTaskManager(ResourceID
resourceId) {
final TaskManagerLocation taskManagerLocation;
try {
- taskManagerLocation =
TaskManagerLocation.fromUnresolvedLocation(unresolvedTaskManagerLocation);
+ final boolean retrieveTaskManagerHostName =
this.jobMasterConfiguration.getConfiguration()
+
.getBoolean(JobManagerOptions.RETRIEVE_TASK_MANAGER_HOSTNAME);
+ if (!retrieveTaskManagerHostName) {
+ log.info("JobManager would not retrieve
TaskManager's canonical hostname due to configuration.");
Review comment:
Yes this is a little verbose to log on every registration, and since we
have already printed all the configuration parameters during startup, this
logging is removed in the new commit : )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
