XComp commented on a change in pull request #13458:
URL: https://github.com/apache/flink/pull/13458#discussion_r509312402
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointStatistics.java
##########
@@ -154,6 +161,7 @@ private CheckpointStatistics(
this.persistedData = persistedData;
this.numSubtasks = numSubtasks;
this.numAckSubtasks = numAckSubtasks;
+ this.checkpointType = checkpointType;
Review comment:
I forgot to mention in the other review: It's always good to call
`Preconditions.checkNotNull` on nullable parameters. See other `status` as an
example.
##########
File path: flink-runtime-web/web-dashboard/src/app/interfaces/job-checkpoint.ts
##########
@@ -114,6 +115,8 @@ export interface CheckPointConfigInterface {
enabled: boolean;
delete_on_cancellation: boolean;
};
+ state_backend: string;
Review comment:
Why did you add the `state_backend` here? It looks like it's not needed?
🤔
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
