wsry commented on pull request #13595: URL: https://github.com/apache/flink/pull/13595#issuecomment-716419919
@StephanEwen `taskmanager.network.sort-shuffle.max-buffers` is only used to control the max required buffers (min size) of the buffer pool now. I have update the code and the calculation logic is as follows: ``` int maxNumberOfMemorySegments = type.isBounded() ? numberOfSubpartitions * networkBuffersPerChannel + floatingNetworkBuffersPerGate : Integer.MAX_VALUE; int numRequiredBuffers = !type.isPipelined() && sortMergeBlockingShuffleEnabled ? Math.min(numberOfSubpartitions + 1, maxBuffersPerSortMergePartition) : numberOfSubpartitions + 1; return bufferPoolFactory.createBufferPool(numRequiredBuffers, maxNumberOfMemorySegments, numberOfSubpartitions, maxBuffersPerChannel); ``` I agree that `taskmanager.network.sort-shuffle.min-parallelism` is more flexible than a boolean flag and I will update the PR and use `taskmanager.network.sort-shuffle.min-parallelism`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
