kl0u commented on a change in pull request #13808:
URL: https://github.com/apache/flink/pull/13808#discussion_r512796678
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/sink/GlobalStreamingCommitterOperatorTest.java
##########
@@ -121,13 +119,18 @@ public void restoredFromMergedState() throws Exception {
testHarness.open();
final List<String> expectedOutput = new ArrayList<>();
-
expectedOutput.add(TestSink.TestGlobalCommitter.COMBINER.apply(input1));
-
expectedOutput.add(TestSink.TestGlobalCommitter.COMBINER.apply(input2));
+
expectedOutput.add(TestSink.DefaultGlobalCommitter.COMBINER.apply(input1));
+
expectedOutput.add(TestSink.DefaultGlobalCommitter.COMBINER.apply(input2));
testHarness.snapshot(1L, 1L);
testHarness.notifyOfCompletedCheckpoint(1L);
testHarness.close();
+ // TODO:: maybe there is no output at all
Review comment:
This should be removed. The base committer class uses the `output`
although it is only needed by the `Committer` and not the `GlobalCommitter`.
This does not seem to be a bug because every operator has an output but if
there is no successor, the elements are simply dropped.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
