guoweiM commented on a change in pull request #13808:
URL: https://github.com/apache/flink/pull/13808#discussion_r513163601
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/sink/GlobalStreamingCommitterOperatorTest.java
##########
@@ -121,13 +119,18 @@ public void restoredFromMergedState() throws Exception {
testHarness.open();
final List<String> expectedOutput = new ArrayList<>();
-
expectedOutput.add(TestSink.TestGlobalCommitter.COMBINER.apply(input1));
-
expectedOutput.add(TestSink.TestGlobalCommitter.COMBINER.apply(input2));
+
expectedOutput.add(TestSink.DefaultGlobalCommitter.COMBINER.apply(input1));
+
expectedOutput.add(TestSink.DefaultGlobalCommitter.COMBINER.apply(input2));
testHarness.snapshot(1L, 1L);
testHarness.notifyOfCompletedCheckpoint(1L);
testHarness.close();
+ // TODO:: maybe there is no output at all
Review comment:
thanks @aljoscha and @kl0u . It would be fix in the next pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
