JingsongLi commented on a change in pull request #13697:
URL: https://github.com/apache/flink/pull/13697#discussion_r513144820
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/BucketFactory.java
##########
@@ -37,6 +39,7 @@
final long initialPartCounter,
final BucketWriter<IN, BucketID> bucketWriter,
final RollingPolicy<IN, BucketID> rollingPolicy,
+ @Nullable final FileLifeCycleListener<IN, BucketID>
fileListener,
Review comment:
https://flink.apache.org/contributing/code-style-and-quality-java.html#java-optional
In Flink code style, it is recommended to use the `Optional` only in method
return values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
