JingsongLi commented on a change in pull request #13697:
URL: https://github.com/apache/flink/pull/13697#discussion_r513147361
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java
##########
@@ -251,14 +254,20 @@ T withBucketFactory(final BucketFactory<IN, BucketID>
factory) {
return self();
}
+ @Internal
+ @Override
Review comment:
Sorry, let me explain the context:
In the file compaction, we need to write a file with the specified name. We
hope to use `BucketWriter` to complete atomic file level writing.
The `BucketWriter` can complete atomic writing, but also shield the
implementation details of BulkWriter, RowWiseWriter, OutputStreamBasedWriting
and PathBasedWriting. That's great.
It's like the `createBuckets` method, We can not let it be package-private,
because it is used by another module (flink-table).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
