zentol edited a comment on pull request #13796: URL: https://github.com/apache/flink/pull/13796#issuecomment-718130365
There is no benefit in having the generated files in git, it could just be step of the release process. It will imply a second packaging step. (compile + save output -> generate NOTICE -> repackage) On CI we would compile Flink and pipe the build output into a file, then run the generator with this file as input to ensure that the NOTICE files can be generated. > I've quickly looked at building our own shade resource transformer FYI: Last time I tried it wasn't possible to write custom transformers (it _looks_ like you can, but I always had classpath issues), and even if you could it would interfere with other transformers touching the notice file (like the appender), because a file can only be touched by at most 1 transformer. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
