pyscala commented on a change in pull request #13834:
URL: https://github.com/apache/flink/pull/13834#discussion_r514891230
##########
File path:
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/RowDataToCsvConverters.java
##########
@@ -128,7 +128,7 @@ private static RowFieldConverter
createRowFieldConverter(LogicalType fieldType)
case DATE:
return (csvMapper, container, row, pos) ->
convertDate(row.getInt(pos), container);
case TIME_WITHOUT_TIME_ZONE:
- return (csvMapper, container, row, pos) ->
convertTime(row.getInt(pos), container);
+ return (csvMapper, container, row, pos) ->
convertTime(row.getLong(pos), container);
Review comment:
Will overflow when supporting nanosecond precision in the future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
