pyscala commented on a change in pull request #13834:
URL: https://github.com/apache/flink/pull/13834#discussion_r514886707
##########
File path:
flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvRowDataSerDeSchemaTest.java
##########
@@ -109,6 +109,54 @@ public void testSerializeDeserialize() throws Exception {
new byte[] {107, 3, 11});
}
+ @Test
+ public void testSerializeDeserializeForTime() throws Exception {
+ testFieldForTime(
+ TIME(3),
+ "12:12:12.232",
+ "12:12:12.232",
+ (deserSchema) -> deserSchema.setNullLiteral("null"),
+ (serSchema) -> serSchema.setNullLiteral("null"),
Review comment:
For example, the input is "12:12:12.232", but the precision is 2, then
the result should be "12:12:12.23". The existing test named `testNullableField
` must be modified to meet the needs of this test. But the change affects other
test cases. So i add a new test methed named `testFieldForTime`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
