HuangXingBo commented on a change in pull request #13838:
URL: https://github.com/apache/flink/pull/13838#discussion_r515775411
##########
File path: flink-python/pyflink/common/execution_config.py
##########
@@ -673,7 +674,7 @@ def is_use_snapshot_compression(self):
"""
return self._j_execution_config.isUseSnapshotCompression()
- def set_use_snapshot_compression(self, use_snapshot_compression):
+ def set_use_snapshot_compression(self, use_snapshot_compression: bool):
"""
Review comment:
Yes. Make sense.
##########
File path: flink-python/pyflink/common/execution_config.py
##########
@@ -673,7 +674,7 @@ def is_use_snapshot_compression(self):
"""
return self._j_execution_config.isUseSnapshotCompression()
- def set_use_snapshot_compression(self, use_snapshot_compression):
+ def set_use_snapshot_compression(self, use_snapshot_compression: bool):
"""
Control whether the compression (snappy) for keyed state in full
checkpoints and savepoints
Review comment:
The implementation of these methods is aligned with the java side, if
the implementation is changed, it may not be convenient for users
##########
File path: flink-python/pyflink/datastream/checkpoint_config.py
##########
@@ -268,15 +268,15 @@ def get_externalized_checkpoint_cleanup(self):
cleanup_mode =
self._j_checkpoint_config.getExternalizedCheckpointCleanup()
return
ExternalizedCheckpointCleanup._from_j_externalized_checkpoint_cleanup(cleanup_mode)
- def is_unaligned_checkpoints_enabled(self):
+ def is_unaligned_checkpoints_enabled(self) -> bool:
"""
Returns whether unaligned checkpoints are enabled.
:return: ``True`` if unaligned checkpoints are enabled.
"""
return self._j_checkpoint_config.isUnalignedCheckpointsEnabled()
- def enable_unaligned_checkpoints(self, enabled=True):
+ def enable_unaligned_checkpoints(self, enabled: bool = True):
"""
Enables unaligned checkpoints, which greatly reduce checkpointing
times under backpressure.
Review comment:
Yes. Make sense
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
