dianfu commented on a change in pull request #13838:
URL: https://github.com/apache/flink/pull/13838#discussion_r516431377
##########
File path: flink-python/pyflink/common/configuration.py
##########
@@ -24,13 +28,12 @@ class Configuration:
Lightweight configuration object which stores key/value pairs.
"""
- def __init__(self, other=None, j_configuration=None):
+ def __init__(self, other: 'Configuration' = None, j_configuration:
JavaObject = None):
"""
Creates a new configuration.
:param other: Optional, if this parameter exists, creates a new
configuration with a
copy of the given configuration.
- :type other: Configuration
:param j_configuration: Optional, the py4j java configuration object,
if this parameter
exists, creates a wrapper for it.
:type j_configuration: py4j.java_gateway.JavaObject
Review comment:
could be removed
##########
File path: flink-python/pyflink/common/execution_config.py
##########
@@ -92,7 +93,7 @@ def disable_closure_cleaner(self):
self._j_execution_config =
self._j_execution_config.disableClosureCleaner()
return self
- def is_closure_cleaner_enabled(self):
+ def is_closure_cleaner_enabled(self) -> 'ExecutionConfig':
Review comment:
bool
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
