rkhachatryan commented on a change in pull request #13735:
URL: https://github.com/apache/flink/pull/13735#discussion_r517403672



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java
##########
@@ -620,18 +758,112 @@ private static void checkStateMappingCompleteness(
                        chainOpParallelStates,
                        oldParallelism,
                        newParallelism);
+       }
+
+       static class TaskStateAssignment {

Review comment:
       1. Yes, but IIUC `TaskStateAssignment` could be added before
   2. Reviewing is one reason, but also in general why some helper code 
shouldn't reside in a separate file? Member lookup would be easier for example
   
   However, it's probably a matter of taste.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to