rkhachatryan commented on a change in pull request #13735:
URL: https://github.com/apache/flink/pull/13735#discussion_r517414170
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/partitioner/ForwardPartitioner.java
##########
@@ -43,4 +44,14 @@ public int
selectChannel(SerializationDelegate<StreamRecord<T>> record) {
public String toString() {
return "FORWARD";
}
+
+ @Override
+ public ChannelStateRescaler getUpstreamChannelStateRescaler() {
+ return ChannelStateRescaler.FIRST_CHANNEL;
+ }
+
+ @Override
+ public ChannelStateRescaler getDownstreamChannelStateRescaler() {
+ return ChannelStateRescaler.ROUND_ROBIN;
Review comment:
I agree about using `ROUND_ROBIN` for the upstream.
My concern was mostly about the dowstream (which should be resolved by
addressing the comment
[below](https://github.com/apache/flink/pull/13735#discussion_r517176106)).
As for `boolean`, I'd prefer `ChannelStateRescaler` as it's more flexible
and consistent (with downstream).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
