wangyang0918 commented on a change in pull request #13871: URL: https://github.com/apache/flink/pull/13871#discussion_r518538862
########## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/highavailability/KubernetesCheckpointIDCounter.java ########## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.highavailability; + +import org.apache.flink.api.common.JobStatus; +import org.apache.flink.kubernetes.kubeclient.FlinkKubeClient; +import org.apache.flink.kubernetes.kubeclient.resources.KubernetesConfigMap; +import org.apache.flink.kubernetes.kubeclient.resources.KubernetesException; +import org.apache.flink.kubernetes.kubeclient.resources.KubernetesLeaderElector; +import org.apache.flink.runtime.checkpoint.CheckpointIDCounter; +import org.apache.flink.util.FlinkRuntimeException; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.Optional; +import java.util.concurrent.atomic.AtomicLong; + +import static org.apache.flink.kubernetes.utils.Constants.CHECKPOINT_COUNTER_KEY; +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * {@link CheckpointIDCounter} implementation for Kubernetes. The counter will be stored in + * JobManager-{@link org.apache.flink.api.common.JobID}-leader ConfigMap. The key is + * {@link org.apache.flink.kubernetes.utils.Constants#CHECKPOINT_COUNTER_KEY}, + * and value is counter value. + */ +public class KubernetesCheckpointIDCounter implements CheckpointIDCounter { + + private static final Logger LOG = LoggerFactory.getLogger(KubernetesCheckpointIDCounter.class); + + private final FlinkKubeClient kubeClient; + + private final String configMapName; + + private final String lockIdentity; + + private volatile boolean running; Review comment: Yes. You are right. Just like `DefaultCompletedCheckpointStore`, `KubernetesCheckpointIDCounter` is also not thread-safe. So `volatile` of `running` is unnecessary. BTW, I think `CheckpointCoordinator` could guarantee that there's no concurrent `shutdown` and `getAndIncrement`. I will simply remove the `volatile`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
