xintongsong commented on a change in pull request #13871:
URL: https://github.com/apache/flink/pull/13871#discussion_r518579393
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/TestingRetrievableStateStorageHelper.java
##########
@@ -41,22 +64,43 @@
private final T state;
- private TestingRetrievableStateHandle(T state) {
+ private FunctionWithException<T, T, IOException>
retrieveStateFunction;
+
+ private RunnableWithException discardStateRunnable;
+
+ private Function<T, Long> getStateSizeFunction;
+
+ private TestingRetrievableStateHandle(
+ T state,
+ FunctionWithException<T, T, IOException>
retrieveStateFunction,
+ RunnableWithException discardStateRunnable,
+ Function<T, Long> getStateSizeFunction) {
this.state = state;
+ this.retrieveStateFunction = retrieveStateFunction;
Review comment:
No. I mean we do not need the argument `state` for the constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
