tillrohrmann opened a new pull request #13968:
URL: https://github.com/apache/flink/pull/13968
## What is the purpose of the change
59f19e8:
In order to avoid deadlocks in LeaderElectionDrivers which call
onGrantLeadership and revokeLeadership
under an internal lock, we must not close the LeaderElectionDriver under the
DefaultLeaderElectionService.lock.
f233b9c:
In order to avoid seeing LeaderContender callbacks after the
DefaultLeaderElectionService
has been shut down, they need to be executed under the lock of the service.
This entails
that the user of this class should not close the service under the same lock
as the
callback can acquire.
052df91:
This commit moves the closing of the leaderRetrievalDriver used by the
DefaultLeaderRetrievalService
out of the lock scope. This ensures that if the LeaderRetrievalDriver
triggers callbacks while holding a lock,
then we won't deadlock.
Moreover, this commit moves the LeaderRetrievalListener callback back under
the lock scope in order to avoid
callbacks after the DefaultLeaderRetrievalService has been closed.
cc @wangyang0918
## Verifying this change
- Added
`DefaultLeaderElectionServiceTest.testServiceShutDownWithSynchronizedDriver`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**yes** / no /
don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
