tillrohrmann commented on a change in pull request #13968:
URL: https://github.com/apache/flink/pull/13968#discussion_r518811401
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java
##########
@@ -292,13 +287,13 @@ public void onFatalError(Throwable throwable) {
}
return;
}
- }
- // The contender callback should be executed out of
lock to avoid potential deadlock.
- if (throwable instanceof LeaderElectionException) {
-
leaderContender.handleError((LeaderElectionException) throwable);
- } else {
- leaderContender.handleError(new
LeaderElectionException(throwable));
+ // The contender callback should be executed
out of lock to avoid potential deadlock.
Review comment:
True, I will remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
