twalthr commented on a change in pull request #13770:
URL: https://github.com/apache/flink/pull/13770#discussion_r519159919
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/table/RowDataFieldsKinesisPartitioner.java
##########
@@ -224,13 +251,17 @@ public boolean equals(Object o) {
}
final RowDataFieldsKinesisPartitioner that =
(RowDataFieldsKinesisPartitioner) o;
return Objects.equals(this.fieldNames, that.fieldNames) &&
- Arrays.equals(this.fixedPrefix, that.fixedPrefix);
+ Objects.equals(this.staticFields, that.staticFields) &&
+ Objects.equals(this.keyBufferStaticPrefixLength,
that.keyBufferStaticPrefixLength) &&
+ Objects.equals(this.fieldNamesStaticPrefixLength,
that.fieldNamesStaticPrefixLength);
}
@Override
public int hashCode() {
return Objects.hash(
fieldNames,
- Arrays.hashCode(fixedPrefix));
+ staticFields,
+ this.keyBufferStaticPrefixLength,
+ this.keyBufferStaticPrefixLength);
Review comment:
nit: we can remove the `this`
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/table/KinesisOptions.java
##########
@@ -44,26 +49,54 @@
private KinesisOptions() {
}
- //
--------------------------------------------------------------------------------------------
+ //
-----------------------------------------------------------------------------------------
// Kinesis specific options
- //
--------------------------------------------------------------------------------------------
+ //
-----------------------------------------------------------------------------------------
/**
- * Prefix for properties delegated to the
+ * Prefix for properties defined in
+ * {@link
org.apache.flink.streaming.connectors.kinesis.config.AWSConfigConstants}
+ * that are delegated to
* {@link
org.apache.flink.streaming.connectors.kinesis.FlinkKinesisConsumer} and
* {@link
org.apache.flink.streaming.connectors.kinesis.FlinkKinesisProducer}.
*/
- public static final String PROPERTIES_PREFIX = "properties.";
+ public static final String AWS_PROPERTIES_PREFIX = "aws.";
+
+ /**
+ * Prefix for properties defined in
+ * {@link
org.apache.flink.streaming.connectors.kinesis.config.ConsumerConfigConstants}
+ * that are delegated to
+ * {@link
org.apache.flink.streaming.connectors.kinesis.FlinkKinesisConsumer}.
+ */
+ public static final String CONSUMER_PREFIX = "source.";
Review comment:
I'm very sorry. Somehow I missed this in the Google docs document.
Instead of `source` we should use `scan` according to FLIP-122. Because we have
two types of sources, we should make it clear that all these properties related
to a table scan and not a lookup source.
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/table/RowDataFieldsKinesisPartitioner.java
##########
@@ -224,13 +251,17 @@ public boolean equals(Object o) {
}
final RowDataFieldsKinesisPartitioner that =
(RowDataFieldsKinesisPartitioner) o;
return Objects.equals(this.fieldNames, that.fieldNames) &&
- Arrays.equals(this.fixedPrefix, that.fixedPrefix);
+ Objects.equals(this.staticFields, that.staticFields) &&
+ Objects.equals(this.keyBufferStaticPrefixLength,
that.keyBufferStaticPrefixLength) &&
+ Objects.equals(this.fieldNamesStaticPrefixLength,
that.fieldNamesStaticPrefixLength);
}
@Override
public int hashCode() {
return Objects.hash(
fieldNames,
- Arrays.hashCode(fixedPrefix));
+ staticFields,
+ this.keyBufferStaticPrefixLength,
+ this.keyBufferStaticPrefixLength);
Review comment:
should be `fieldNamesStaticPrefixLength`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
