[
https://issues.apache.org/jira/browse/FLINK-20043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227979#comment-17227979
]
Alexander Alexandrov edited comment on FLINK-20043 at 11/8/20, 12:05 PM:
-------------------------------------------------------------------------
BTW, unlike {{flink-connector-kafka}} and
{{flink-connector-elasticsearch[6|7]}} the Maven jars published by the
{{flink-connector-kinesis}} package are already fat. In that sense adding a
separate {{flink-sql-connector-kinesis}} package doing the same thing seems
like unnecessary overhead.
Should I remove [the {{maven-shade-plugin}} configuration in
{{flink-connector-kinesis}}
|https://github.com/apache/flink/blob/322a357f96bf60d3a89fd39ab4ae972bb272a758/flink-connectors/flink-connector-kinesis/pom.xml#L256-L330]as
part of this change? This breaks the assumptions made of existing clients
(essentially from 1.12.x if I want the fat jar I will have to pull the
{{flink-sql-connector-kinesis}} package, even if I am not using the Table API
or SQL features.
was (Author: aalexandrov):
BTW, unlike {{flink-connector-kafka}} and
\{{flink-connector-elasticsearch[6|7]}}, the Maven jars published by the
{{flink-connector-kinesis}} package are already fat. In that sense adding a
separate {{flink-sql-connector-kinesis}} package doing the same thing seems
like unnecessary overhead.
Should I remove [the {{maven-shade-plugin}} configuration in
{{flink-connector-kinesis}}
|https://github.com/apache/flink/blob/322a357f96bf60d3a89fd39ab4ae972bb272a758/flink-connectors/flink-connector-kinesis/pom.xml#L256-L330]as
part of this change? This breaks the assumptions made of existing clients
(essentially from 1.12.x if I want the fat jar I will have to pull the
{{flink-sql-connector-kinesis}} package, even if I am not using the Table API
or SQL features.
> Add flink-sql-connector-kinesis package
> ---------------------------------------
>
> Key: FLINK-20043
> URL: https://issues.apache.org/jira/browse/FLINK-20043
> Project: Flink
> Issue Type: Improvement
> Reporter: Alexander Alexandrov
> Assignee: Alexander Alexandrov
> Priority: Major
> Attachments: third-party-report.html
>
>
> This is a follow up item after the recent addition of [Kinesis SQL source and
> sink in PR #13770 |https://github.com/apache/flink/pull/13770].
> Create a package that bundles a fat connector jar that can be used by SQL
> clients. See [FLINK-11026|https://issues.apache.org/jira/browse/FLINK-11026]
> and the related PRs for a discussion how to do that.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
